Mobile view calendar improvements #19218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you share a screenshot how this looks now? |
|
|
|
Monthly recheck: This still needs a review. |
bramkragten
reviewed
Feb 2, 2024
| @@ -187,7 +187,7 @@ class PanelCalendar extends LitElement { | |||
| .events=${this._events} | |||
| .calendars=${this._calendars} | |||
| .narrow=${this.narrow} | |||
| .initialView=${this.narrow ? "listWeek" : "dayGridMonth"} | |||
| initialView="dayGridMonth" | |||
There was a problem hiding this comment.
I don't think dayGridMonth works well on small screens, that's why I didn't make it the default there
|
Thanks, this card (and the calendar panel) is currently being re-designed by the product team. But I think we can merge this for now. See my comment. |
bramkragten
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: